asm89 / twig-cache-extension

The missing cache extension for Twig. Caching template fragments with Twig.
MIT License
388 stars 27 forks source link

Different approach for optional event usage in cache providers #19

Closed stloyd closed 8 years ago

stloyd commented 10 years ago

This is alternative approach for code suggested in #14. This approach adds optional dependency on Symfony EventDispatcher component.

stloyd commented 10 years ago

@asm89 Pong =)))

asm89 commented 10 years ago

@stloyd I think we can even do an EventEmittingCacheProvider that can wrap any other? :) No need for a base class in that case.

asm89 commented 8 years ago

I'd like to not introduce the base class, but go for the wrapping approach instead. Closing this PR. :)