search

asm89 / twig-cache-extension

The missing cache extension for Twig. Caching template fragments with Twig.
MIT License
388 stars 27 forks source link

Twig 2 compatibility #30

Closed asm89 closed 8 years ago

asm89 commented 8 years ago

The Twig_NodeInterface interface is deprecated in Twig 1.x and will be removed in Twig 2. Changing Twig_NodeInterface to Twig_Node should make the extension ready to support both Twig 1 and Twig 2 for now.

asm89 commented 8 years ago

@fabpot @stof It seems that this all that's currently needed to make the extensions work with Twig master. Is there anything I'm missing?

OskarStark commented 8 years ago

any news on this PR?

stof commented 8 years ago

@asm89 this change looks good to me

OskarStark commented 8 years ago

thank you for the feedback @stof

fabpot commented 8 years ago

LGTM

asm89 commented 8 years ago

Tagged as 1.2.0.