asm89 / twig-cache-extension

The missing cache extension for Twig. Caching template fragments with Twig.
MIT License
388 stars 27 forks source link

Add PSR-6 compatible adapter #32

Closed rvanlaak closed 8 years ago

rvanlaak commented 8 years ago

Next to the already available DoctrineCacheAdapter this PR adds a PSR-6 compatible adapter, which without any BC break allows to easily implement one of the pools available at:

http://php-cache.readthedocs.io/

In my opinion, and I think @Nyholm agrees with that too, it would be better to completely follow PSR-6 and get rid of all adapters, but that would be a huge BC break. I'd propose to release 1.3.0 after merging.

Nyholm commented 8 years ago

👍 I agree. This is a good way to support PSR6 and whenever we release 2.0 we should remove our cache interface and rely only on PSR6

rvanlaak commented 8 years ago

@Nyholm fixed & rebased PR, ping @asm89

rvanlaak commented 8 years ago

ping @asm89

rvanlaak commented 8 years ago

ping @asm89

asm89 commented 8 years ago

@rvanlaak Thanks for the contribution. This is pretty cool! :)

rvanlaak commented 8 years ago

Thanks @asm89 :+1: Maybe you can also add a note in your readme about the bundle that smoothly integrates your extension into Symfony? And, release version 1.3.0 after that?

Documentation about PSR-6 will be added at that bundle too: https://github.com/EmanueleMinotto/TwigCacheBundle/pull/14

rvanlaak commented 8 years ago

@asm89 can you please release tag 1.3.0?

rvanlaak commented 8 years ago

ping @asm89 :wink:

rvanlaak commented 8 years ago

ping @asm89

rvanlaak commented 8 years ago

ping @asm89

rvanlaak commented 8 years ago

ping @asm89

asm89 commented 8 years ago

https://github.com/asm89/twig-cache-extension/releases/tag/1.3.0