Closed rvanlaak closed 8 years ago
👍 I agree. This is a good way to support PSR6 and whenever we release 2.0 we should remove our cache interface and rely only on PSR6
@Nyholm fixed & rebased PR, ping @asm89
ping @asm89
ping @asm89
@rvanlaak Thanks for the contribution. This is pretty cool! :)
Thanks @asm89 :+1: Maybe you can also add a note in your readme about the bundle that smoothly integrates your extension into Symfony? And, release version 1.3.0
after that?
Documentation about PSR-6 will be added at that bundle too: https://github.com/EmanueleMinotto/TwigCacheBundle/pull/14
@asm89 can you please release tag 1.3.0
?
ping @asm89 :wink:
ping @asm89
ping @asm89
ping @asm89
Next to the already available
DoctrineCacheAdapter
this PR adds a PSR-6 compatible adapter, which without any BC break allows to easily implement one of the pools available at:http://php-cache.readthedocs.io/
In my opinion, and I think @Nyholm agrees with that too, it would be better to completely follow PSR-6 and get rid of all adapters, but that would be a huge BC break. I'd propose to release
1.3.0
after merging.