search

asm89 / twig-cache-extension

The missing cache extension for Twig. Caching template fragments with Twig.
MIT License
388 stars 27 forks source link

Add support cache tags for PSR6 #36

Closed Koc closed 7 years ago

rvanlaak commented 8 years ago

You can close this issue. See https://github.com/asm89/twig-cache-extension/blob/master/lib/Asm89/Twig/CacheExtension/CacheProvider/PsrCacheAdapter.php

Koc commented 8 years ago

No word tag inide this class. How to configure tags when saving block?

rvanlaak commented 8 years ago

What tags do you mean? Cache tags, Twig tags? Can you please elaborate on your issue because it hasn't a description.

Koc commented 8 years ago

https://github.com/symfony/symfony-docs/pull/6947 , chapter "Using Cache Tags"

Nyholm commented 7 years ago

We (Symfony and PHP-cache) is going to share an interface for tags that soon will be a PSR. See https://github.com/symfony/symfony/issues/19728

asm89 commented 7 years ago

Let's re-open an discussion like this once implementations for tagged caching are coming online? The tagging isn't actually part of PSR6, so we'd need implementations for Symfony cache and PHP-Cache specifically in this repository. Not sure what would be the best way of support cache tagging only for those implementation yet, but I'm sure we can figure something out.

patie commented 7 years ago

ping

Nyholm commented 7 years ago

https://github.com/php-cache/tag-interop

Koc commented 7 years ago

@Nyholm do you know when corresponding PSR will be created?

Nyholm commented 7 years ago

It is all upp to me. =)

I've talked with Nicholas Grekas, he is using this interface with Symfony. We are also having discussions with Drupal about it and they are satisfied (not officially tough) with this interface.

Im having conversations with @michaelcullum about submitting new PSRs. Im waiting for his green light.

patie commented 7 years ago

will be nice to possible add tags for twig blocks, with future invalidation possibility, symfony tagged cache feature - https://symfony.com/blog/new-in-symfony-3-2-tagged-cache