search

asmagin / Cake.Sitecore

The library provides a set of pre-build CAKE tasks. Those tasks could be used to simplify a configuration of CI/CD for Helix-based Sitecore projects.
https://cakebuild.net/addins/sitecore/
MIT License
11 stars 12 forks source link

Parameter PUBLISHING_TARGET_DIR should be defined #13

Closed artyom-krot closed 6 years ago

artyom-krot commented 6 years ago

1) Parameter PUBLISHING_TARGET_DIR is not defined in the parameters.cake file. 2) Also I see no where in scripts PUBLISHING_TARGET_DIR will be created. Suggestion: to add EnsureDirectoryExists(Sitecore.Parameters.PublishingTargetDir); to the tasks: .IsDependentOn(Sitecore.Tasks.CopyShipFilesTaskName) .IsDependentOn(Sitecore.Tasks.CopySpeRemotingFilesTaskName) .IsDependentOn(Sitecore.Tasks.PrepareWebConfigTaskName) .IsDependentOn(Sitecore.Tasks.PublishFoundationTaskName) .IsDependentOn(Sitecore.Tasks.PublishFeatureTaskName) .IsDependentOn(Sitecore.Tasks.PublishProjectTaskName)

asmagin commented 6 years ago

PUBLISHING_TARGET_DIR defines a name of an argument or environmental variable. It is defined in constants.cake

It is used in a file parameters.cake inside a function GetPublishingTargetDir to get a value of such argument on environmental variable and assign to a property Sitecore.Parameters.PublishingTargetDir