asmaloney / libE57Format

Library for reading & writing the E57 file format
Boost Software License 1.0
137 stars 66 forks source link

Remove enforcement of warnings as errors #279

Closed SpaceIm closed 5 months ago

SpaceIm commented 10 months ago

Could you revert https://github.com/asmaloney/libE57Format/pull/211 please? It's terrible for package managers to force warnings as errors. Warnings as errors is for library developers, not for users of your library.

There is already an option to enable Warnings as errors, why would you want to prevent someone disabling this option?

I would also advise to not hardcode all these warnings. You could add an option to enable them, beccause again these warnings are for you, users don't care and it can be harmful.