search

asmap / kartograf

MIT License
10 stars 7 forks source link

Incomplete ROAs? #20

Open job opened 1 month ago

job commented 1 month ago

What does this comment mean? https://github.com/fjahr/kartograf/blob/37947d4611230985da39ae18db535f56af01ec8e/kartograf/rpki/parse.py#L31

fjahr commented 2 weeks ago

@job Sorry for the late response! At some point early on I encountered cases where one of the keys that I needed were missing in the result. I don't remember which key it was specifically, it wasn't all of them probably just one. I just added this safe guard afterwards to make sure I we would run into issues in the future. I don't think I have can say which key it was that was missing because I added this very early on when I was just trying to see if it was even possible to make it work. We need to add better detailed logging for debugging, so I we can add this as one of the things to include there.