CI tracking issue - Githubissues

asmap / kartograf

MIT License

11 stars 7 forks source link

CI tracking issue #34

Open jurraca opened 1 week ago

jurraca commented 1 week ago

We should get some CI going. I think the TODO looks something like the below. Would love some input as I haven't done a ton of CI setup before.

[x] Initial configuration: builds the Nix flake and outputs #33
[x] Add linter to CI
[ ] After tests are added, run tests as well
[ ] self-host Github runner ? maybe with this

fjahr commented 1 week ago

Sounds good. I was thinking of having a linter job would be lowest hanging fruit for the start. just pylint and/or flake8, the only real work is figuring out what errors we want to ignore and then fix the rest. I had started that process a few weeks ago and I will open a PR for that asap. I guess I can tag it on to the initial config PR.

jurraca commented 1 week ago

i've been using ruff but I don't have any opinion on the best tool. Are you doing one big linting / formatting pass on the project? figure that's best as its own PR, yea.

fjahr commented 5 days ago

I've never used ruff, we've been using pylint and flake8 in core so that's what I am used to.

I've opened #35 as a start, fixing some of the more interesting errors and marking a few others as ignored for now. We can fix these as we go along but most importantly this should be good to detect some stuff like unused variables and actual errors in code path we might have forgotten to test.