search

asmblah / jemul8

An object-oriented JavaScript x86 Emulator for Node.js and the browser
http://jemul8.com
Other
132 stars 19 forks source link

Removed jquery dependecy from keyboard plugin and corrected tests #9

Closed coderaiser closed 11 years ago

coderaiser commented 11 years ago

Hi Dan, sory for obtrusiveness, I just want to speed up jemul8, if remove jquery dependency or move out it to google cdn if would work a little bit faster. Any way you use it in a couple places and wanted to remove it, as you write in todo of util.js

Corrected tests for pull request https://github.com/asmblah/jemul8/pull/8. Tests works fine in Chrome and FF.

asmblah commented 11 years ago

Hi Coderaiser,

That's great, thank you. I think it would be better to use a "mock" document too, rather than using the test runner page's document.

I'll add some notes to the diff.

asmblah commented 11 years ago

Fixed. In the end I just replaced the document implementation with a stub one to simplify the tests.

Cheers!