Superglobals - Githubissues

IngwiePhoenix commented 8 years ago

While looking at this project: https://github.com/js-cookie/js-cookie ... i realized, Uniter never actually seemed to introduce superglobals.

So I would like to ask, how one would set up the superglobals? Say I want to emulate $COOKIE with this project above, that would mean I'd need:

to setup $COOKIE superglobal.
add cookie_*() functions.
probably add getter and setter for array-key access. (offsetGet kinda stuff).

I can see this being implemented as part of my uniter-stl, which I will likely re-write soon to adapt a bit better and to a nicer structure. But for this to work in general, I'd still need to know how to setup a superglobal, and especially with a way to add getter and setter.

The other superglobals are:

$_SERVER
$_ENV
$_GET
$_POST
$_REQUEST
$_FILES
$_SESSION
$argv / $argc

I could see these being implemented by making them all be raw associative arrays - aka. empty JS objects - by default - which they really are - and giving the user an API to set their value.

// For example:
phpruntime.setSuper("$_SERVER", {HTTP_CONTENT_TYPE: "text/plain"});
phpruntime.setSuper("$_ENV", process.env);
phpruntime.setSuper("$argv", process.argv || ["--some", "arg"]);

A pseudo testcase (jasmine/expect):

var _ = require("microdash");

var object_globals = [
    "$_GET", "$_POST", "$_REQUEST", "$_FILES",
    "$_SERVER", "$_ENV", "$_SESSION"
];

describe("PHPRuntime", function(){
    describe(".setSuper", function(){
        object_globals.forEach(function(globalName){
            it("only accepts an object for: "+globalName, function(){
                var phpruntime = this.phpruntime; // get php runtime
                expect(function() {
                    phpruntime.setSuper(globalName, {foo: "bar"});
                }).not.toThrow; // a TypeErrpr exception
            });
        });

        it("should only accept an array for $argv", function(){
            var phpruntime = this.phpruntime;
            expect(function(){
                phpruntime.setSuper("$argv", {});
            }).toThrow;
            expect(function(){
                phpruntime.setSuper("$argv", []);
            }).not.toThrow;
        });

        it("should automatically match $argc to $argv", function(){
            var phpruntime = this.phpruntime;
            var argv = ["uniter", "foo.php", "--arg1", "--arg2=withSomething"];

            phpruntime.setSuper("$argv", argv);

            expect(phpruntime.getSuper("$argc").length).isEqual(argv.length);
        });

        it("should prevent manipulation of $argc", function(){
            var phpruntime = this.phpruntime;
            expect(function(){
                phpruntime.setSuper("$argc", /* it's over */9000);
            }).toThrow;
        });
    });
});

( Yup, im geting used to unit testing right there! :) )

IngwiePhoenix commented 8 years ago

I just realized my test didnt mention cookies - but, you get what i meant. :)