asmecher / hypothesis

A Hypothes.is integration plugin for OJS
GNU General Public License v3.0
9 stars 16 forks source link

annotations URL #22

Open Ppantaleo opened 7 months ago

Ppantaleo commented 7 months ago

Hi Alec, I see that the plugin Scielo Preprints uses has this section: https://preprints.scielo.org/index.php/scielo/annotations But I install it on a server I am setting up, I load a comment on the PDF and I can't access this URL: https://domain/server-name/annotations

I have removed in index.php from my URL

Thanks

JhonathanLepidus commented 7 months ago

Hi!

The annotations page is a feature we have developed to be used in the SciELO Preprints server. However, we didn't send it to be available in the original plugin yet. Can you confirm if you're using the original Hypothesis plugin?

Ppantaleo commented 7 months ago

Hello, thank you for your reply. Yes, I am implementing it in a preprint soon to be launched and I would be interested in adding that feature as well.

diegoabadan commented 7 months ago

Thanks @Ppantaleo .

Ideally, we'd like to integrate the changes we've made into the official plugin, if Alec/PKP agree.

There are three features:

@asmecher , would you like to receive a PR with these changes? Presently, we only have them for OPS 3.3.

asmecher commented 7 months ago

Yes, I'd be very happy to review a PR for this, thanks! It would make the plugin a lot more useful.

Ppantaleo commented 7 months ago

Great, thanks!