search

asmecher / hypothesis

A Hypothes.is integration plugin for OJS
GNU General Public License v3.0
10 stars 15 forks source link

PDF.js plugin problems in FireFox / Safari #8

Open lpmagnuson opened 4 years ago

lpmagnuson commented 4 years ago

Hi, I attempted to install this plugin in our OJS instance but activating the plugin and attempting to make the required PDF changes results in the PDFs not actually loading in the browser in FireFox and Safari (the PDF viewer loads, along with the hypothesis tools, but the actual PDF content itself never loads). The integration seems to work perfectly with Chrome. I saw this comment/issue that seems to indicate that perhaps the PDF.js plugin that's included in OJS is no longer compatible; is there any solution to potentially get this working? I did have to hack the included PDF.js plugin a bit since the referenced .diff patch wouldn't work with our existing PDF.js install (which is the same one that comes packaged with OJS 3.x).

Thanks for developing this and for any help!

Lauren

asmecher commented 4 years ago

@lpmagnuson, until the work is done in the issue you linked above, it's unfortunately necessary to choose between either a current PDF.js PDF reader, or Hypothes.is integration with an old one. The Hypothes.is team manages the integration between PDF.js and Hypothes.is; the PKP team (that includes me) just manage the integration between either product and OJS. It might be helpful if you threw in a +1 on the other issue.