search

asmeurer / blog

My blog
https://www.asmeurer.com/blog/
8 stars 2 forks source link

GitHub Reviews Gripes | Aaron Meurer's Blog #12

Open utterances-bot opened 3 years ago

utterances-bot commented 3 years ago

GitHub Reviews Gripes | Aaron Meurer's Blog

https://asmeurer.com/blog/posts/github-reviews-gripes/

asmeurer commented 3 years ago

To comment on this post, click on "Sign in with GitHub" below. If you don't want to authorize the Utterances bot, you can go to the GitHub issues page for this post and comment there.

asmeurer commented 3 years ago

These are the original comments on this post that were made when this blog used the Disqus blog system.

Comment from Ned Batchelder on 2016-10-06 09:48:29+00:00:

These are all excellent points.

If I can pile on my own gripes:

1) Once I've requested changes, the front page has a status of "nedbat has requested changes" (or something). The author pushes some more commits. Now how do I find the changes I've requested? I have to flip to the diff page and Cmd-F search the page for my name!

2) If the author has fixed three of my seven requests, but hasn't quite gotten it right on the other four, how do I indicate that? We've reverted to old-school comment conventions.

3) Now more often than not, the notification emails don't link to a specific place in the pull request. I get the "We can't find those commits" message. GitHub: you sent me the email based on something that *just* happened in the pull request!! How can the link already be broken?

To be honest, this feels like a feature that was rushed out the door in time for the annual conference.

Comment from Nick Coghlan on 2016-10-06 09:59:18+00:00:

Changing the default behaviour of inline comments is the one that really gets me. All they had to do to make that transition seamless was to keep the old behaviour of immediate comments as the default, and add a new button that transitioned between the two states: starting a new review (if there wasn't one active) and finishing the current review (if a review was already in progress).

That way folks that only pressed the old button would always stay in "Immediate commenting" mode, while folks that switched to delayed commenting would have a "Complete review" button readily available every time they made a comment.

(FWIW I actually like being able to do proper batched reviews ala Gerrit and Rietveld, but changing a long established default to something a lot of enterprises are likely to prefer without any notice looks suspiciously like a Business Development group winning a UX argument they should have conceded)