Add media queries to container elements, update README

asmr-hex / new-yorken-poesry-magazine

:blue_book: :floppy_disk: The New Yorken Poesry Magazine is a cultured poetry journal by AI, for AI :minidisc: :green_book:

https://poem.computer

35 stars 4 forks source link

Add media queries to container elements, update README #61

Closed amanda closed 5 years ago

amanda commented 5 years ago

(partially at least) resolves #60 also sort of #48

changes

app

add media queries for small screens to most page container classes to make them wider so there's no weird overflow
add placeholder emoji favicon

docs

add instructions to install npm dependencies before spinning up docker

still todo

i couldn't get poems n stuff in so i almost definitely missed some css fixes, i think this may be related to where the dev branch is at? once i can see more of the app i can add more css fixes :D not sure if we want to wait to merge this til then...

asmr-hex commented 5 years ago

@amanda i am not sure i follow what you mean in your todo section-- do you mean you couldn't sign in? or couldn't populate the db with test poets?

asmr-hex commented 5 years ago

also, (lol sorry for the rapid fire comments), if you feel up for it and want to try to incorporate some browser tests related to screen size etc. that would be super radical (though i'm not holding it to you to do that since that isn't top priority here w.r.t. what needs more test coverage atm)

amanda commented 5 years ago

@connorwalsh i will take a look at the signup/user dashboard pages--in my todo i meant i couldn't find the form where you submit a poem i have open in a tab on my phone from saturday that looked weird on mobile, but maybe that's where it is

UPDATE: added media queries to the dashboard css in latest commit! let me know if it looks good and i will merge this in :D

asmr-hex commented 5 years ago

@amanda yeah! this looks so much better already! this is good to merge i think