search

aso2101 / satavahana-inscriptions

1 stars 0 forks source link

Issue with places found/mentioned overlap #55

Open wsalesky opened 7 years ago

wsalesky commented 7 years ago

RE: https://github.com/aso2101/satavahana-inscriptions/pull/54

wsalesky commented 7 years ago

Added place-type attribute to inscriptions returned in browse results to prevent places found/mentioned overlap.

aso2101 commented 7 years ago

Great. This seems to solve most of the issues I noted: if a place is only mentioned in an inscription, it doesn't show up on the list.

There is something that I would like to correct, however, about the list of inscriptions at each place. Even when the filter is set to "Places where inscriptions are found," the inscriptions returned by app:browse-display-hits include inscriptions where the given place is merely mentioned. Here are some examples:

Similarly, when the "places mentioned in inscriptions" filter is selected, the inscriptions list for each place includes inscriptions that don't mention the place in question.

I wonder if it is possible to change app:browse-display-hits and app:view-hits to be sensitive to the filter on places.html, such that if "places where inscriptions are found" is selected, then it will only match places that are reported origPlace, and if "places mentioned in inscriptions" is selected, it will only match places that are reported in div[@type='edition']. (If so, the text "Mentioned in these inscriptions" in app:browse-display-hits can also be changed depending on the filter.)

wsalesky commented 7 years ago

How does this look: https://github.com/aso2101/satavahana-inscriptions/tree/issue55