search

asok / all-the-icons-ivy

all-the-icons.el for Ivy/Counsel
95 stars 9 forks source link

display correct icon for directories #5

Closed wedens closed 5 years ago

wedens commented 6 years ago

Observed: counsel-find-file displays some incorrect generic icons for directories: image

Expected: Detect when candidate is a directory and use (all-the-icons-octicon "file-directory") icon.

asok commented 5 years ago

Sorry for a late response. About your issue - I'm just calling all-the-icons' function all-the-icons-icon-for-file. And this is the icon returned by it. I think that we could improve here by having the directory icon have colors instead of a simple shades.

asok commented 5 years ago

@wedens I've pushed version 0.4.0 that should look better: screen shot 2019-01-14 at 09 50 47

wedens commented 5 years ago

@asok thanks!