search

asok / projectile-rails

Emacs Rails mode based on projectile
258 stars 59 forks source link

Replace cl with cl-lib #145

Closed wkirschbaum closed 4 years ago

wkirschbaum commented 4 years ago

cl is deprecated, so want to replace it with cl-lib.

The intention is mostly get rid of the annoying message "Package cl is deprecated".

There is currently still an issues where lexical-let is replaced with let, where this was changed to prevent an ivy-resume issue: https://github.com/asok/projectile-rails/commit/d31af287b2228f855e0bfbc5f985f999e5b5f811 Just testing locally with ivy, I don't see it being an issue

I tested on my local setup with both helm and ivy and seem to work. I am very new to elisp, so not sure how to test it better.

asok commented 4 years ago

Thanks for the contribution. I'm sorry for a late response.

asok commented 4 years ago

@wkirschbaum I need to debug an issue I'm having on the current master with the snippets expansions. After that I can merge in your improvement.