asok / projectile-rails

Emacs Rails mode based on projectile
258 stars 59 forks source link

edits to eliminate byte-compilation warnings in emacs 28 #161

Closed jmay closed 2 years ago

jmay commented 2 years ago

This is purely to clear out warnings when emacs 28 aggressively attempts to byte-compile everything.

purcell commented 2 years ago

Thanks for looking at this. Re. the long docstrings, this is not quite the correct fix, because those now make checkdoc unhappy. The right fix is usually to wordsmith the function descriptions until the first sentence is short enough. Extra info can go into subsequent sentences.

jmay commented 2 years ago

Cool, I never knew about this! I'll run this and apply all its recommendations.

purcell commented 2 years ago

Great, thanks — merged.