asolfre / hackerskeyboard

Automatically exported from code.google.com/p/hackerskeyboard
0 stars 0 forks source link

Fullscreen editor in landscape mode is not enabled on Samsung GT-i8150 #281

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
When using Hacker's Keyboard v1.33 on the Samsung Galaxy W (GT-I8150) phone, 
the landscape mode fullscreen editor is not activated even if the “Landscape 
mode fullscreen editor” option is set to “Enabled on small devices” (and 
this is a phone with a 3.7" 480x800 screen). This makes Hacker's Keyboard 
unusable with some applications in landscape orientation, because there is not 
enough space left on the screen.

I am using the latest stock firmware currently available for the GT-I8150 in 
Russia (I8150XXLM6, released in May 2012; Android 2.3.6).

I have looked at the “Device Details” page in Dalvik Explorer, and it seems 
that the firmware is reporting wrong DPI for the screen:

-------------------------------------------------------------------
Screen Density: 240dpi (1.5x DIP)
Screen Size: 480 x 800 pixels
Exact DPI: 160.42105 x 160.0
Approximate Dimensions: 3,0" x 5,0" (5,8" diagonal)
-------------------------------------------------------------------

Actually the screen size is 48mm x 80mm (254dpi).

Because it is unlikely that Samsung will release a firmware update for this 
model which fixes the reported DPI (apparently the model is EOL now), could 
some workaround for such bugs be added to Hacker's Keyboard (like a manual 
override to always show the fullscreen landscape editor)?

Original issue reported on code.google.com by sigp...@gmail.com on 21 Aug 2012 at 4:48

GoogleCodeExporter commented 9 years ago
Apparently between Gingerbread and ICS the original code in LatinIME was first 
changed to use "dip" instead of "in" in the fullscreen check (which should fix 
this particular problem):

https://github.com/CyanogenMod/android_packages_inputmethods_LatinIME/commit/f80
b6a06992ae08ca3601f4fbc6da550fd9ac730

and then immediately changed to a completely different method to determine the 
appropriate mode:

https://github.com/CyanogenMod/android_packages_inputmethods_LatinIME/commit/2be
872555c08a66a820695ca6961e18d02dec359

Original comment by sigp...@gmail.com on 11 Sep 2012 at 8:45

GoogleCodeExporter commented 9 years ago
Thanks for the code pointers, I can merge the modified algorithm to make the 
default selection work better.

I'm also thinking about replacing the current checkbox with a tristate menu 
selection, so that it defaults to "whatever the device thinks is appropriate", 
and providing additional options to force the fullscreen editor on or off.

Original comment by Klaus.We...@gmail.com on 28 Sep 2012 at 6:05