search

asomers / gstat-rs

An enhanced version of FreeBSD's gstat(8) utility
BSD 2-Clause "Simplified" License
14 stars 0 forks source link

Exporter port collision #43

Open lapo-luchini opened 3 months ago

lapo-luchini commented 3 months ago

I noticed that this exporter uses port 9248 which is reserved to gstat exporter.

While content is similar in intention, the format used and the data available is different and this exporter is not a drop-in replacement for that one, so I thing it would make sense for people (including myself) to use both while migrating dashboards, so it would be better to register a new ports specific for this exporter, so that by default they do not conflict.

-gstat_queue_depth{descr="KINGSTON SA400S37240G",fwheads="16",fwsectors="63",ident="50026B73825128F3",lunid="50026b73825128f3",mediasize="240057409536 (224G)",name="ada2",rotationrate="0",sectorsize="512"} 0.0
+geom_queue_length{device="ada2"} 0
-gstat_miliseconds_per_write{descr="KINGSTON SA400S37240G",fwheads="16",fwsectors="63",ident="50026B73825128F3",lunid="50026b73825128f3",mediasize="240057409536 (224G)",name="ada2",rotationrate="0",sectorsize="512"} 0.7
+geom_duration{device="ada2",method="write"} 117.63482913172801
asomers commented 3 months ago

I chose that port number deliberately because there are very few unused ports available, and it should be very rare that somebody wants to use geom-exporter and gstat-exporter at the same time. Migration would be an obvious exception. But port 9248 is merely the default. You can always override it with geom-exporter's -p option. Is that not good enough?