search

asomers / ztop

Display ZFS datasets' I/O in real time
BSD 2-Clause "Simplified" License
69 stars 7 forks source link

TTY state not correctly restored on exit when using bash #37

Closed asomers closed 9 months ago

asomers commented 9 months ago

When the login terminal is bash, terminal settings will not be correctly reset on exit. When the login terminal is fish, everything works fine.

I have bisected this bug to 271a7e5a6894738363da3bb37a49c7257e028a36

Steps to Reproduce

  1. cargo run
  2. press 'q'
  3. type "stty" and hit enter
  4. observe this garbled output: 
    speed 9600 baud;
            lflags: -icanon -isig -iexten -echo echoke echoctl
                                                              iflags: -icrnl -ixon -ixany -imaxbel ignbrk -brkint
                                                                                                                 oflags: -opost tab0
                                                                                                                                    cflags: cs8 -parenb
  5. Type anything else and observe that commands aren't visibly echoed to the screen