search

asotog / squeezebox

Simple Angular 2 accordion component
19 stars 8 forks source link

Is there any Reason to leave the empty href in the <a> Tag? #4

Closed SpecialNick closed 7 years ago

SpecialNick commented 7 years ago

Hello,

I was wondering if it was of any use to keep the "href="#"' attribute in the tag for the sbItemHead.

I personally would enjoy it if you would remove it because all it does is add the link you are clicking in the corner:

image

Maybe you could even add a CSS-Class for even easier styling?

SpecialNick commented 7 years ago

@asotog ?

asotog commented 7 years ago

Yeah i think that might be removed, is not needed

asotog commented 7 years ago

wait @SpecialNick but how are you getting # in the address bar ? i meant the click event has preventDefault(), https://github.com/asotog/squeezebox/blob/master/components/sb-item-head.ts#L18

SpecialNick commented 7 years ago

I'm not getting the # in the adress bar, it just shows up in the bottom left/right corner when hovering over the sbItemHead

If you open your example plunker and get it in a pop up window then you can recreate it: unbenannt

to bad you apparently can't see my mouse when I'm taking a screenshot >.< But I am hovering over "Item 1" in above screenshot

asotog commented 7 years ago

no worries got it