search

asottile / dockerfile

Parse a dockerfile into a high-level representation using the official go parser
MIT License
95 stars 18 forks source link

Windows wheels #158

Closed bindreams closed 11 months ago

bindreams commented 11 months ago

Hello again. I saw #157 and nothing immediately jumped out at me as being amiss, so I tried to replicate the windows pipeline from simple actions. Apparently windows does build after all, though I'm not sure what is the difference between my pipeline and yours.

Would you be able to use this as a starting point to reopening and solving #156? I would be happy to assist further if necessary.

asottile commented 11 months ago

nah I don't think the bug is here. it's somewhere else

bindreams commented 11 months ago

Just to clarify - I ran the github actions on my fork and the wheels DO build - check out https://github.com/andreasxp/dockerfile/actions/runs/5700227090 This is the same code in this PR - if you approve the workflow the same result will be here.

asottile commented 11 months ago

yeah to be clear I'm solving this a different way. the difference between the two is virtualenv

bindreams commented 11 months ago

yeah to be clear I'm solving this

Let me know if I understood you correctly - you're saying you are working on #156 after all?

asottile commented 11 months ago

yes but the problem is not here