search

aspace-sim / aspace

ASpace space simulator for the PennMUSH MU* Server
11 stars 6 forks source link

fixes local_fun_cdb #13

Closed mloftis closed 3 years ago

mloftis commented 3 years ago

removes weird-and-unnecessary for loop setting pe_regs fixes use-after-free for correctly working code fall through for case statement moved to the correct location. and most importantly, actually fires EXECUTE on all in-range registered objects instead of just the lowest numbered one

mloftis commented 3 years ago

Part of this bug (the for loop 10x on pe_regs) is probably...ISTR there being a "global" stack for %N's back when I was the maintaner for Paradox, and you had to push that aside so it didn't get clobbered. I looked at the stdw "fork" published here and that confirms that suspicion. As for the switch statement's default: case getting broken by ending up in the cdb iterate, I know when working on aspace before I had trouble tracking the nesting. Anyway...this SHOULD fix this version so cdb does as it says on the tin. Quick thrown together softcode against this just-fixed space_main.c does as intended, pinging every in-range cdb.