aspacek / Letterboxd-user-film-compare

Will find the similarity in Letterboxd film ratings between two users, a user and who they're following, or a user and their followers.
0 stars 0 forks source link

Get the workflow working #2

Closed aspacek closed 4 years ago

aspacek commented 4 years ago

Trying to use main.yml to have the program running regularly and to make sure it's working. I barely know what I'm doing, so the goal is to try to get it actually working.

aspacek commented 4 years ago

Added main.yml workflow file to the appropriate file path, I think. Now I have to wait for it to trigger and run, which should be Saturday March 28 at 4am MDT. We'll see what happens.

aspacek commented 4 years ago

Edited main.yml file so that it worked with an edited main file I manually made (removing any human input requests), and it ran successfully. Now I've tried to use artifacts to have the workflow create the edited main file itself, and then run it. We'll see what happens in the morning.

Note: Next I'd like to add some sort of check on the output, to make sure the results look correct, and maybe to make sure the timing is reasonable.

aspacek commented 4 years ago

Note: I'd also like to test all Python 3.x version, just to see if it works for all of them or if it's limited.

aspacek commented 4 years ago

Got it working finally, on the below commit. I'm going to leave this open for now to address the 2 above notes: 1) output check, timing check 2) test all python 3.x versions

https://github.com/aspacek/Letterboxd-user-film-compare/commit/c75fefa2b9248b8c7d2512df5ae4e61b3e85a3e8

aspacek commented 4 years ago

Adding another note:

  1. check all types of runs (user vs user, user following, user followers)
aspacek commented 4 years ago

Added output check for all 3 comparison systems, including timing checks. Added a test for all Python 3.x versions See below commit.

Still need to do (#)3 above: checking user following and user followers runs

https://github.com/aspacek/Letterboxd-user-film-compare/commit/36d953718d2ada7807c7036184651b9e1b6de5fe

aspacek commented 4 years ago

Added basic checks for following and followers, but really need to do some serious thinking about how best to automate this workflow and check that the program is working. Commit below.

https://github.com/aspacek/Letterboxd-user-film-compare/commit/892a309065eb529e83bd898e243210d3662992c7