aspangaro / oblyon

Oblyon theme for Dolibarr ERP & CRM
https://www.dolibiz.com/
Other
65 stars 57 forks source link

Contract expired services link #157

Closed MaximilienR-easya closed 5 months ago

MaximilienR-easya commented 5 months ago

À partir de Dolibarr 18 dans : > commerce/contrats abonnements/services/services expirés

Le filtre "expirés" ne s'active pas et Dolibarr donne une liste non filtrée.

Le fix serait de remplacer dans : core/menus/standard/oblyon.lib.php

1093                    $newmenu->add("/contrat/services_list.php?leftmenu=contracts&mode=0", $langs->trans("MenuInactiveServices"), 2, $user->rights->contrat->lire);
1094                    $newmenu->add("/contrat/services_list.php?leftmenu=contracts&mode=4", $langs->trans("MenuRunningServices"), 2, $user->rights->contrat->lire);
1095                    $newmenu->add("/contrat/services_list.php?leftmenu=contracts&mode=4&filter=expired", $langs->trans("MenuExpiredServices"), 2, $user->rights->contrat->lire);
1096                    $newmenu->add("/contrat/services_list.php?leftmenu=contracts&mode=5", $langs->trans("MenuClosedServices"), 2, $user->rights->contrat->lire);

par

                    $newmenu->add("/contrat/services_list.php?leftmenu=contracts&search_status=0", $langs->trans("MenuInactiveServices"), 2, $user->rights->contrat->lire);
                    $newmenu->add("/contrat/services_list.php?leftmenu=contracts&search_status=4", $langs->trans("MenuRunningServices"), 2, $user->rights->contrat->lire);
                    $newmenu->add("/contrat/services_list.php?leftmenu=contracts&search_status=4%26filter=expired", $langs->trans("MenuExpiredServices"), 2, $user->rights->contrat->lire);
                    $newmenu->add("/contrat/services_list.php?leftmenu=contracts&search_status=5", $langs->trans("MenuClosedServices"), 2, $user->rights->contrat->lire);
aspangaro commented 5 months ago

Thanks @MaximilienR-easya for your contribution.

I proposed another PR to manage version 14 to 17 in Oblyon https://github.com/aspangaro/oblyon/releases/tag/3.0.3