aspect-build / aspect-workflows-template

Scaffolding for new Aspect workspace
1 stars 1 forks source link

chore: enable buildifier formatting check #47

Closed alexeagle closed 2 months ago

alexeagle commented 2 months ago

It literally took me two hours to get all the hyphens in the right spots to make it remain formatted along every conditional path.

Note that I could update to a newer scaffold that has a "post" hook feature, but then every user will observe that format running after stamping it out, so this is better (even if really annoying)


Changes are visible to end-users: no

Test plan

mattem commented 2 months ago

so this is better

maybe, This requires a high level of effort to maintain, something that I reckon will slip quickly (a fly by contributor is unlikely to spend the 2 hours getting this right), so I think we need to figure the post process out, and hide the output or something.

alexeagle commented 2 months ago

Yeah I agree. I spent nearly one hour of that on a single pathological location (top of the root BUILD) and eventually learned a technique that helps (de-sugar the hyphens until you have it right). So we'll see...