search

aspect-build / aspect-workflows-template

Scaffolding for new Aspect workspace
1 stars 1 forks source link

refactor(python): support multiple requirements.in #56

Closed alexeagle closed 1 month ago

alexeagle commented 2 months ago

This allows the non-Bazel workflow to still pin or install test dependencies in isolation.

Note that install of pytest is intentional to prepare for adding some py_test workflow next.

Now that there's yet another update command required when dependencies change, I've introduced a repin.sh script. This can be the cheap version of https://github.com/aspect-build/aspect-cli/issues/687 - when we like the DX I can bake the result into Aspect CLI.

alexeagle commented 2 months ago

@jab FYI, does this meet your expectations? Note that I don't bother pinning test.txt here since Bazel wouldn't need to read it - but if you ran some external tooling you might still want that created?

Also LMK if you're interested in being a collaborator on this repo!

jab commented 2 months ago

Note that I don't bother pinning test.txt here since Bazel wouldn't need to read it - but if you ran some external tooling you might still want that created?

My hunch is that starting with just runtime.txt and all.txt (as you've done here) sufficiently covers the main goal here, and it's nice to avoid the complexity of an additional test.txt. Not unreasonable to expect a user who needs that intermediate lockfile to figure out how to generate it based on what's now generated out-of-the-box, IMO.

Also LMK if you're interested in being a collaborator on this repo!

Sure, thanks!