aspect-build / bazel-lib

Common useful functions for writing BUILD files and Starlark macros/rules
https://docs.aspect.build/rules/aspect_bazel_lib
Apache License 2.0
128 stars 75 forks source link

ci: enforce PR titles are semantic #823

Closed alexeagle closed 1 month ago

alexeagle commented 1 month ago

We want contributors to follow the instructions in the PR template, and use conventional commits to indicate the type of the PR.

Note, this uses the amannn upstream to check the title. We could use aspect-forks instead to check the description as well: https://github.com/aspect-forks/action-semantic-pull-request/blob/main/src/validatePrDescription.js


Changes are visible to end-users: no

Test plan

will observe it running

aspect-workflows[bot] commented 1 month ago

Test

3 test targets passed

Targets
//lib/tests/copy_to_directory_bin_action:test [k8-opt] 87ms
//lib/tests/jq:check_stamped [k8-opt]                  121ms
//lib/tests/yq:check_stamped [k8-opt]                  22ms

Total test execution time was 230ms. 224 tests (98.7%) were fully cached saving 39s.


Test

e2e/copy_to_directory

Waiting for runner...


Test

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 578ms.


Test

e2e/external_copy_to_directory

:warning: CircleCI build #3288 failed.

@com_github_bmatcuk_doublestar_v4//:doublestar failed to build

no such package '@com_github_bmatcuk_doublestar_v4//': no such package
'@bazel_gazelle_go_repository_config//': no such package '@bazel_gazelle_go_repository_tools//':
list_repository_tools_srcs: Timed out

@org_golang_x_exp//maps:maps failed to build

no such package '@org_golang_x_exp//maps': no such package '@bazel_gazelle_go_repository_config//': no such
package '@bazel_gazelle_go_repository_tools//': list_repository_tools_srcs: Timed out

:bulb: To reproduce the build failures, run

bazel build @com_github_bmatcuk_doublestar_v4//:doublestar @org_golang_x_exp//maps:maps

Test

e2e/smoke

:warning: CircleCI build #3288 failed.

@com_github_bmatcuk_doublestar_v4//:doublestar failed to build

no such package '@com_github_bmatcuk_doublestar_v4//': no such package
'@bazel_gazelle_go_repository_config//': no such package '@bazel_gazelle_go_repository_tools//': failed to
build tools: Timed out

@org_golang_x_exp//maps:maps failed to build

no such package '@org_golang_x_exp//maps': no such package '@bazel_gazelle_go_repository_config//': no such
package '@bazel_gazelle_go_repository_tools//': failed to build tools: Timed out
no such package '@org_golang_x_exp//maps': no such package '@bazel_gazelle_go_repository_config//': no such
package '@bazel_gazelle_go_repository_tools//': failed to build tools: Timed out

:bulb: To reproduce the build failures, run

bazel build @com_github_bmatcuk_doublestar_v4//:doublestar @org_golang_x_exp//maps:maps

Buildifier      Format      Gazelle