search

aspect-build / bazel-lib

Common useful functions for writing BUILD files and Starlark macros/rules
https://docs.aspect.build/rules/aspect_bazel_lib
Apache License 2.0
131 stars 82 forks source link

[FR]: tar is non-hermetic when compress is set to zstd #877

Closed ewhauser closed 4 weeks ago

ewhauser commented 1 month ago

What is the current behavior?

When tar is configured using compress = "zstd", it looks for zstd on the path. If the zstd_toolchain is registered, then we should append this to path.

Describe the feature

We want to make tar hermetic when using zstd compression.

alexeagle commented 1 month ago

The bug is actually in the BCR entry for libarchive, see https://github.com/aspect-build/bazel-lib/pull/878#issuecomment-2225981766