feat: Add prefix attribute to s3_sync rule

[hashken]

---

Changes are visible to end-users: yes

• Searched for relevant documentation and updated as needed: yes
• Breaking change (forces users to change their own code or config): no
• Suggested release notes appear below: yes

Add option prefix to s3_sync rule to copy files to a specific prefix in the bucket.

Test plan

• Manual testing; please provide instructions so we can reproduce:

bazel run examples/release_to_s3 resulted in a file in the expected bucket. Note: While testing, updated the bucket name in examples/release_to_s3/BUILD to a bucket where I have access.

[CLAassistant]

All committers have signed the CLA.

[alexeagle]

I think the issue is actually just documentation, the example didn't show that we meant "bucket plus prefix"

So I don't think we need the complexity of a new attribute or flag.

For example this is what we have in Aspect's monorepo using this feature:

SILO_VEGA_AWS_INSTALL_BUCKET = "aw-install-4430499330980957/0.0.0-PLACEHOLDER"

and

s3.release(
    name = "us_east_1_release",
    bucket = "aspect-artifacts-us-east-1/{{STABLE_SILO_WORKFLOWS_VERSION}}/workflows",
    profile = "root",
    sync_archive = True,
    tags = [],  # not deliverable
    targets = [":workflows_assets"],
)

[hashken]

I think the issue is actually just documentation, the example didn't show that we meant "bucket plus prefix"

So I don't think we need the complexity of a new attribute or flag.

For example this is what we have in Aspect's monorepo using this feature:

SILO_VEGA_AWS_INSTALL_BUCKET = "aw-install-4430499330980957/0.0.0-PLACEHOLDER"

and

s3.release(
    name = "us_east_1_release",
    bucket = "aspect-artifacts-us-east-1/{{STABLE_SILO_WORKFLOWS_VERSION}}/workflows",
    profile = "root",
    sync_archive = True,
    tags = [],  # not deliverable
    targets = [":workflows_assets"],
)

Ouch. That makes sense. Should have caught that 🤦🏽

Closing this PR.

[alexeagle]

I think #67 fixes the missing docs by using a prefix in the example