feat(s3_sync): allow string for bucket in addition to file - Githubissues

aspect-build / rules_aws

EXPERIMENTAL: Bazel Integration for Amazon Web Services

Other

10 stars 1 forks source link

feat(s3_sync): allow string for bucket in addition to file #67

Closed alexeagle closed 4 months ago

alexeagle commented 4 months ago

Also clarify in examples that the bucket attribute accepts any S3 path

Changes are visible to end-users: yes

Searched for relevant documentation and updated as needed: yes
Breaking change (forces users to change their own code or config): yes - but the bucket attribute was just released yesterday
Suggested release notes appear below: yes

s3_push#bucket is now a literal string. Use the bucket_file to read the bucket from a file.

Test plan

Manual testing; please provide instructions so we can reproduce: Ran the two example targets