search

aspect-build / rules_esbuild

Bazel rules for https://esbuild.github.io/ JS bundler
https://docs.aspect.build/rules/aspect_rules_esbuild
Apache License 2.0
27 stars 27 forks source link

docs: note args --> config migration #123

Closed Aghassi closed 1 year ago

Aghassi commented 1 year ago

This ensures that folks know that config is the replacement for args when coming from @bazel/esbuild. This is an issue I hit, see this discussion in slack https://bazelbuild.slack.com/archives/CEZUUKQ6P/p1675462695407799?thread_ts=1674525810.470589&cid=CEZUUKQ6P

CC @mattem @gregmagolan

alexeagle commented 1 year ago

I think it would be better just to make a separate docs/migration.md with whatever table of replace-this-with-that or other notes you've got.

Aghassi commented 1 year ago

I think it would be better just to make a separate docs/migration.md with whatever table of replace-this-with-that or other notes you've got.

This is the only arg I have to replace currently it seems, but I'm happy to do that too. I probably need to do this for each of the rules. Would you prefer that?

alexeagle commented 1 year ago

just merging to cleanup PRs