search

aspect-build / rules_esbuild

Bazel rules for https://esbuild.github.io/ JS bundler
https://docs.aspect.build/rules/aspect_rules_esbuild
Apache License 2.0
27 stars 27 forks source link

fix: don't ignore tsconfig field on user config #135

Closed gregmagolan closed 1 year ago

gregmagolan commented 1 year ago

Looks like tsconfig was set in the old rules_nodejs @bazel/esbuild version of this rule (for path mappings) but it is no longer load bearing in rules_esbuild.

See https://bazelbuild.slack.com/archives/CEZUUKQ6P/p1678478456514209 for more context.

alexeagle commented 1 year ago

I don't remember why we had to pass tsconfig before, I think @mattem worked on that one. Removal sounds right based on your analysis

gregmagolan commented 1 year ago

I don't remember why we had to pass tsconfig before, I think @mattem worked on that one. Removal sounds right based on your analysis

I believe we were auto-generating a tsconfig file with the path mappings from deps which is not longer a use case under rules_js