search

aspect-build / rules_esbuild

Bazel rules for https://esbuild.github.io/ JS bundler
https://docs.aspect.build/rules/aspect_rules_esbuild
Apache License 2.0
27 stars 27 forks source link

add npm-links sample #35

Closed JiaLiPassion closed 2 years ago

JiaLiPassion commented 2 years ago

Add npm-links sample to describe how to use esbuild rule with npm_link_package rule. The sample is based on @jbedard 's sample https://github.com/jbedard/rules_esbuild/tree/npm-link-package/e2e/npm-links

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

jbedard commented 2 years ago

Want to also add a 3rd-party npm module that also gets imported by the consumer?

JiaLiPassion commented 2 years ago

@jbedard , I added the 3rd party lib sample.

JiaLiPassion commented 2 years ago

@jbedard , @alexeagle , I updated the PR and add the sample to ci. Since the transitive dependency issue will not be resolved in the near future, I removed the sample about that part. Please review, thank you.