search

aspect-build / rules_esbuild

Bazel rules for https://esbuild.github.io/ JS bundler
https://docs.aspect.build/rules/aspect_rules_esbuild
Apache License 2.0
27 stars 27 forks source link

e2e: add e2e test showing transitive npm dependencies #36

Closed jbedard closed 2 years ago

jbedard commented 2 years ago

This is similar to https://github.com/aspect-build/rules_esbuild/pull/35 except failing tests, with both ts_project and js_library. Seems to be because npm_package does not pass dependencies along. What does npm_link_all_packages do differently?

jbedard commented 2 years ago

This seems to be the intended npm_package behavior

matthewjh commented 2 years ago

Related? https://github.com/aspect-build/rules_ts/issues/96

jbedard commented 2 years ago

@matthewjh yes that's the same issue