search

aspect-build / rules_js

High-performance Bazel rules for running Node.js tools and building JavaScript projects
https://docs.aspect.build/rules/aspect_rules_js
Apache License 2.0
298 stars 103 forks source link

[Bug]: Missing test for js_library "sandwich" no-type-check #1847

Closed alexeagle closed 3 weeks ago

alexeagle commented 1 month ago

What happened?

verify we don't eager-type-check a test/devserver that deps through to a 1p package

Version

Development (host) and target OS/architectures:

Output of bazel --version:

Version of the Aspect rules, or other relevant rules from your WORKSPACE or MODULE.bazel file:

Language(s) and/or frameworks involved:

How to reproduce

No response

Any other information?

slack context: https://aspect-build.slack.com/archives/C02KYA0UZ4K/p1720813137299539

alexeagle commented 1 month ago

Also we should update https://github.com/aspect-build/rules_ts/blob/main/docs/transpiler.md#avoid-eager-type-checks-via-npm_package