fix(npm): use labels for npm_translate_lock(replace_packages)

aspect-build / rules_js

High-performance Bazel rules for running Node.js tools and building JavaScript projects

https://docs.aspect.build/rules/aspect_rules_js

Apache License 2.0

310 stars 107 forks source link

fix(npm): use labels for npm_translate_lock(replace_packages) #1885

Closed jbedard closed 3 months ago

jbedard commented 3 months ago

This way real labels are passed through to the underlying rule which should handle bzlmod repository mappings.

Changes are visible to end-users: no

Test plan

Covered by existing test cases

jbedard commented 3 months ago

This attempt to avoid breaking changes will not work. The wksp macro can change without breaking changes by making the npm_translate_lock macro switch to label:pkgs but that is not possible with bzlmod.

See https://github.com/aspect-build/rules_js/pull/1886 for alternate bzlmod API.