Open ramzesucr opened 1 week ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
2 test targets passed
//js/private/test/js_run_devserver:js_run_devserver_test [k8-fastbuild] 378ms //js/private/test/js_run_devserver:node_modules_symlink_to_execroot_test [k8-fastbuild] 422ms
Total test execution time was 800ms. 209 tests (99.1%) were fully cached saving 33s.
All tests were cache hits
5 tests (100.0%) were fully cached saving 857ms.
All tests were cache hits
2 tests (100.0%) were fully cached saving 503ms.
All tests were cache hits
1 test (100.0%) was fully cached saving 7s.
All tests were cache hits
3 tests (100.0%) were fully cached saving 820ms.
All tests were cache hits
3 tests (100.0%) were fully cached saving 1s.
All tests were cache hits
1 test (100.0%) was fully cached saving 34ms.
All tests were cache hits
1 test (100.0%) was fully cached saving 34ms.
All tests were cache hits
2 tests (100.0%) were fully cached saving 171ms.
All tests were cache hits
1 test (100.0%) was fully cached saving 129ms.
All tests were cache hits
3 tests (100.0%) were fully cached saving 503ms.
All tests were cache hits
1 test (100.0%) was fully cached saving 222ms.
All tests were cache hits
1 test (100.0%) was fully cached saving 131ms.
All tests were cache hits
1 test (100.0%) was fully cached saving 131ms.
All tests were cache hits
1 test (100.0%) was fully cached saving 590ms.
All tests were cache hits
40 tests (100.0%) were fully cached saving 3s.
All tests were cache hits
10 tests (100.0%) were fully cached saving 3s.
All tests were cache hits
12 tests (100.0%) were fully cached saving 2s.
All tests were cache hits
2 tests (100.0%) were fully cached saving 474ms.
All tests were cache hits
2 tests (100.0%) were fully cached saving 470ms.
All tests were cache hits
1 test (100.0%) was fully cached saving 443ms.
All tests were cache hits
1 test (100.0%) was fully cached saving 199ms.
Tools like vite have hot reload feature which is useful during development. This feature works when js_run_devserver and ibazel are used. Current experience feels weird due to long reload time thus it invalidates the usage of hot reload. In order to have a better performance I propose synchronizing the non node_module files directly from workspace
workspace source
->devserver sandbox
, instread of currentworkspace source
->bazel-out
->devserver sandbox
behaviour. It might not work for every use case, so it's hidden behind direct_sync attribute. The file sync is still necessary after bazel build sincenode_modules
might have changed.Changes are visible to end-users: yes/no
Test plan