search

aspect-build / rules_py

More compatible Bazel rules for running Python tools and building Python projects
Apache License 2.0
86 stars 28 forks source link

Add backwards compatible types to file generated by __test__.py #441

Closed hofbi closed 6 days ago

hofbi commented 6 days ago

As suggested in https://github.com/aspect-build/rules_py/pull/435#issuecomment-2482658330 a backwards compatible (< Python 3.9) type hint.

Regardless of merging this PR or not, the current 1.0.0 release is broken for < Python 3.9. Since Python 3.8 is already EOL, this is in theory valid, but I guess there are still a few people using Python 3.8 because of Ubuntu 20.04.

Changes are visible to end-users: no

Test plan

hofbi commented 6 days ago

When looking for test cases, I found https://github.com/aspect-build/rules_py/blob/97aff2461348c841aeb13d3e2cea0bcb27c26845/examples/multi_version/BUILD.bazel#L26 which seems to test with Python 3.8, hence I would expect that this test should have failed.

mattem commented 6 days ago

Thanks 🙌
Yeah the tests never ran on #428 as the author hadn't submitted a PR to rules_py before, and I missed clicking the "Approve Workflow Run" to run the tests, and it seems the settings on this repo allows merging with no CI results. If this is green I can merge this and tag a v1.0.1.