search

aspect-build / rules_swc

Bazel rules for the swc toolchain https://swc.rs/
https://docs.aspect.build/rules/aspect_rules_swc
Apache License 2.0
44 stars 24 forks source link

chore: update to rules_js 1.15.1 and aspect_bazel_lib 1.23.3 #151

Closed gregmagolan closed 1 year ago

alexeagle commented 1 year ago

This isn't actually necessary for anything, right? End users can upgrade rules_js independently of rules_swc, we shouldn't always need to advance the minimum version unless something is breaking.

gregmagolan commented 1 year ago

Its actually hard to reason about what is breaking between bazel-lib & rules_js and the other rulesets in a downstream WORKSPACE. If a user calls rules_swc_dependencies before rules_js_dependencies in their WORKSPACE and gets an older version of aspect_bazel_lib than rules_js requires than it could break. bzlmod makes it simpler to reason about but for WORKSPACEs it is best to keep all the rules_js downstream rulesets up to date with the latest of the rules_js ecosystem.

alexeagle commented 1 year ago

Okay I see that failure mode, but of course the user could just use the rules_swc version prior to this one, get the older aspect_bazel_lib, and have that problem. There's no need for us to update MODULE.bazel in these "bump" PRs, we both agree, but then it's strange for us to have different versions in the two files. There's also no need to publish to BCR if the only commits are no-op changes to the MODULE.bazel file.

I suppose we're going to slow down rules_js at this point so this will just go away, and we'll rely on bzlmod in the future so we can stop doing these bumps.

gregmagolan commented 1 year ago

Yeah. There are still failure modes. The advice of upgrading all aspect rule sets in a single PR should always work at least.