test: paths should resolve without sandbox directories

jackvincentnz commented 4 months ago

Overview

I have been trying to figure out whether this issue is in SWC or rules_swc. For now I am going to leave this here since it is a simple reproduction of the issue I am seeing. For a more in depth reproduction of this working outside Bazel, please see: https://github.com/jackvincentnz/bazel-swc-paths-bug-repo

Motivation

Minimal reproduction of sandbox paths being present in transpiled javascript after swc transpilation of .ts imports using tsconfig paths.
Bundling the transpiled sources is impossible because the resolved path is not accessible to another downstream action.

Type of change

Reproduction of issue

Test plan

New test cases added

Summary

Sandbox paths are present in transpiled sources when the module being transformed is nested from the baseUrl configured in .swcrc.

E.g. we expected to see paths resolved to their relative paths:

const _moduleB = require("../moduleB");

But instead we see a sandbox path:

const _moduleB = require("../../../../../../../../../../private/var/tmp/_bazel_jack.vincent/bfa0af320da1536c766f4c861b78e1af/sandbox/darwin-sandbox/6/execroot/aspect_rules_swc/examples/paths/src/modules/moduleB");

jackvincentnz commented 4 months ago

build --modify_execution_info=SWCTranspile=+no-sandbox doesn't seem to make this pass, as mentioned it might in https://github.com/swc-project/swc/issues/4057#issuecomment-1118001633

alexeagle commented 1 month ago

This will be fixed by #216 which was unblocked yesterday thanks to an upstream fix in SWC

aspect-build / rules_swc