search

aspect-build / rules_swc

Bazel rules for the swc toolchain https://swc.rs/
https://docs.aspect.build/rules/aspect_rules_swc
Apache License 2.0
41 stars 21 forks source link

Clean up rule implementation #79

Closed dzbarsky closed 1 year ago

dzbarsky commented 1 year ago

This PR cleans up a few things: 1) Removes some duplication between the outdir vs out-files branches 2) Removes some unused output lists 3) Changes how we emit progress_message to avoid constructing strings at analysis time. The message will change slightly for the per-file action (it will have the full src path instead of the short path) but these actions are so quick that I doubt anyone will notice.

jbedard commented 1 year ago

Nice work 👍

Just one minor comment...

jbedard commented 1 year ago

@dzbarsky you requested a review but I see no changes. Forget to push?

dzbarsky commented 1 year ago

@dzbarsky you requested a review but I see no changes. Forget to push?

Yep, sorry about that. Could you also kick off the CI run please?