search

aspect-build / rules_ts

Bazel rules for the `tsc` compiler from http://typescriptlang.org
https://docs.aspect.build/rules/aspect_rules_ts
Apache License 2.0
94 stars 53 forks source link

feat: support incompatible_enable_proto_toolchain_resolution #608

Closed alexeagle closed 1 month ago

alexeagle commented 1 month ago

See https://github.com/bazelbuild/rules_proto/discussions/213

Changes are visible to end-users: no

It will cause bzlmod users to get rules_proto 6.0.0 in their resolved dependencies, which is technically breaking.

Test plan

Note, we could add automated e2e testing for the --noincompatible_enable_proto_toolchain_resolution path as well - feels like overkill given that the conditional logic is all using upstream helpers

aspect-workflows[bot] commented 1 month ago

Test

All tests were cache hits

74 tests (100.0%) were fully cached saving 14s.

Buildifier      Format