aspect-build / rules_ts

Bazel rules for the `tsc` compiler from http://typescriptlang.org
https://docs.aspect.build/rules/aspect_rules_ts
Apache License 2.0
104 stars 58 forks source link

fix(ts_proto_library): require explicit srcs to copy #617

Closed alexeagle closed 4 months ago

alexeagle commented 4 months ago

The hack of using a glob over the srcs causes a collision when there is more than one ts_proto_library in a bazel package. The resulting error doesn't give a clue what fix is required.


Changes are visible to end-users: yes

When ts_proto_library#copy_files is True, users must now repeat the .proto files whose outputs should be copied.

Test plan

CLAassistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.

aspect-workflows[bot] commented 4 months ago

Test

4 test targets passed

Targets
//docs:update_1_test [k8-fastbuild]                              35ms
//examples/proto_grpc:main [k8-fastbuild]                        202ms
//examples/proto_grpc:status_ts_proto.copy_0_test [k8-fastbuild] 49ms
//examples/proto_grpc:status_ts_proto.copy_1_test [k8-fastbuild] 43ms

Total test execution time was 329ms. 75 tests (94.9%) were fully cached saving 10s.


Buildifier      Format