aspect-build / rules_ts

Bazel rules for the `tsc` compiler from http://typescriptlang.org
https://docs.aspect.build/rules/aspect_rules_ts
Apache License 2.0
94 stars 53 forks source link

fix(ts_proto_library): require explicit srcs to copy (#617) #618

Closed alexeagle closed 1 month ago

alexeagle commented 1 month ago

Backport this commit to 2.x branch

error: Error in directory_path: directory_path rule '_logger_pb.d.ts_dirpath' in package 'examples/proto_grpc' conflicts with existing directory_path rule

The hack of using a glob over the srcs causes a collision when there is more than one ts_proto_library in a bazel package. The resulting error doesn't give a clue what fix is required.

aspect-workflows[bot] commented 1 month ago

Test

All tests were cache hits

79 tests (100.0%) were fully cached saving 10s.


Buildifier      Format