search

aspect-build / rules_ts

Bazel rules for the `tsc` compiler from http://typescriptlang.org
https://docs.aspect.build/rules/aspect_rules_ts
Apache License 2.0
104 stars 58 forks source link

chore: add --check_direct_dependencies to .bazelrc #625

Closed gregmagolan closed 3 months ago

gregmagolan commented 3 months ago

Setting this flag in our the rule sets we maintain. Don’t want to push a rules author to update their deps if not needed.

https://bazel.build/reference/command-line-reference#flag--check_direct_dependencies

https://bazelbuild.slack.com/archives/C014RARENH0/p1691158021917459?thread_ts=1691156601.420349&cid=C014RARENH0

aspect-workflows[bot] commented 3 months ago

Test

All tests were cache hits

79 tests (100.0%) were fully cached saving 10s.

Buildifier      Format

alexeagle commented 1 month ago

Note, I just added this to bazel-lib presets, since we think all our rules and customers should have it?

gregmagolan commented 1 month ago

Note, I just added this to bazel-lib presets, since we think all our rules and customers should have it?

We just want this off for rule sets right? Default is warning and is correct for terminal workspaces.