search

aspect-build / toolchains_protoc

Pre-built protoc binary toolchain for Bazel, fetched from official protobuf releases
Apache License 2.0
22 stars 3 forks source link

chore: ensure we don't try to compile any C++ code #16

Closed alexeagle closed 4 months ago

alexeagle commented 5 months ago

We don't have any C++ code in this repo, and want to make sure that our examples don't transitively depend on building protoc from source.

13 should have been red due to the issue I fixed in https://github.com/protocolbuffers/protobuf/pull/17078

This change ensures that PR and any others that regress will be caught by CI.

It should be the case that users with a broken or non-hermetic CC toolchain are still able to work with Protocol Buffers.

alexeagle commented 5 months ago

@fmeum this fails for the wrong reason: rules_go doesn't ship with a binary of the Go stdlib. We discussed that in some thread on Slack I think.

Can you suggest a different way to prevent transitives from accidentally compiling protoc from source? I want that to be a hard fail if it occurs.

fmeum commented 4 months ago

I sent https://github.com/aspect-build/toolchains_protoc/pull/17