aspect-build / toolchains_protoc

Pre-built protoc binary toolchain for Bazel, fetched from official protobuf releases
Apache License 2.0
22 stars 3 forks source link

Disable CGo #17

Closed fmeum closed 4 months ago

fmeum commented 4 months ago

Changes are visible to end-users: yes/no

Test plan

fmeum commented 4 months ago

Is there any consequence for compiling the stdlib without cgo support? Is it possible to change it in rules_go instead to be "pure" so it doesn't attempt to use a cc toolchain?

The non-Bazel Go toolchain also uses CGo on Linux if available and we wouldn't want to deviate from that. The differences are minor, but do affect subtle things like DNS resolution.

(makes me wonder if --host_platform be renamed --exec_platform to match how the cfg attribute on rule declaration is changing...)

I think it's named appropriately in this case as it really is the platform of the machine running bazel. Everything else should go into --extra_execution_platforms.

alexeagle commented 4 months ago

Nice thanks for answering :)