aspect-build / toolchains_protoc

Pre-built protoc binary toolchain for Bazel, fetched from official protobuf releases
Apache License 2.0
22 stars 3 forks source link

feature request: @toolchains_protoc//:protoc target #4

Closed aran closed 6 months ago

aran commented 7 months ago

rules_rust has rust_prost_toolchain: https://bazelbuild.github.io/rules_rust/flatten.html#rust_prost_toolchain which wants a proto_compiler option. That can currently be @protobuf//:protoc.

It would be useful if I could drop in @toolchains_protoc//:protoc there.

aran commented 6 months ago

I guess the other way is to wait for protoc toolchain support to mature and modify rules_rust's rule to access its protoc from the toolchain rather than an explicit parameter.

alexeagle commented 6 months ago

The latter is correct, it should be similar to https://github.com/bazelbuild/rules_go/issues/3895

I'll file with rules_rust.

aran commented 6 months ago

Should be solved elsewhere per above

alexeagle commented 6 months ago

https://github.com/bazelbuild/rules_rust/issues/2627